RFR: 8300295: [AIX] TestDaemonDestroy fails due to !is_primordial_thread assertion [v3]

[David Holmes]

On Fri, 27 Jan 2023 08:06:54 GMT, Varada M <duke at openjdk.org> wrote:

>> The assertion failure with exit value 134 for the test TestDaemonDestroy.java is because when the JNI_CreateJavaVM is being called by main thread on AIX it prevents the jvm creation on the primordial thread on AIX. This is solved in such a way that when JNI_CreateJavaVM is called it runs in pthread thus enabling the creation of jvm. 
>> 
>> JBS issue for this test : [JDK-8300295](https://bugs.openjdk.org/browse/JDK-8300295)
>
> Varada M has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8300295: [AIX] TestDaemonDestroy fails due to !is_primordial_thread assertion

test/hotspot/jtreg/runtime/jni/daemonDestroy/exedaemonDestroy.c line 123:

> 121:    args.argc = argc;
> 122:    args.argv = argv;
> 123:    #ifdef AIX

ifdef's are not indented

test/hotspot/jtreg/runtime/jni/daemonDestroy/exedaemonDestroy.c line 131:

> 129:    pthread_attr_setguardsize(&attr, 0);
> 130:    pthread_attr_setstacksize(&attr, adjusted_stack_size);
> 131:    pthread_create (&id,&attr,run,(void *)&args);

Style nit: no space before (
Style nit: spaces after commas

test/hotspot/jtreg/runtime/jni/daemonDestroy/exedaemonDestroy.c line 132:

> 130:    pthread_attr_setstacksize(&attr, adjusted_stack_size);
> 131:    pthread_create (&id,&attr,run,(void *)&args);
> 132:    pthread_join(id,NULL);

Style nit: spaces after commas

-------------

PR: https://git.openjdk.org/jdk/pull/12006