RFR: 8300295: [AIX] TestDaemonDestroy fails due to !is_primordial_thread assertion [v5]
Varada M
duke at openjdk.org
Wed Feb 1 13:49:52 UTC 2023
On Wed, 1 Feb 2023 12:31:23 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Varada M has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Indentation Fixes
>
> test/hotspot/jtreg/runtime/jni/daemonDestroy/exedaemonDestroy.c line 130:
>
>> 128: pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_JOINABLE);
>> 129: pthread_attr_setguardsize(&attr, 0);
>> 130: pthread_attr_setstacksize(&attr, adjusted_stack_size);
>
> Do we really need this? All other platforms seem to live fine with the default stack size.
> OTOH primordial thread stack default size and pthread default stack size may differ, maybe its better to be explicit.
When NULL is passed as argument `pthread_create(&id, NULL, run, (void *)&args)` , the test is failing with an exit value 139. To solve that i have included the functions `pthread_attr_setdetachstate` , `pthread_attr_setguardsize` and `pthread_attr_setstacksize` to set attributes for the thread.
Commenting `pthread_attr_setdetachstate` and `pthread_attr_setguardsize` the test has passed. I will update it here.
Thank you @tstuefe
-------------
PR: https://git.openjdk.org/jdk/pull/12006
More information about the hotspot-runtime-dev
mailing list