Integrated: JDK-8301513: Replace NULL with nullptr in os_cpu/windows_x86

[Johan Sjölen]

On Tue, 31 Jan 2023 11:43:36 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory os_cpu/windows_x86. Unfortunately the script that does the change isn't perfect, and so we
> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
> 
> Here are some typical things to look out for:
> 
> 1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
> 2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
> 3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
> 
> An example of this:
> 
> ```c++
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
> 
> 
> Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
> 
> Thanks!

This pull request has now been integrated.

Changeset: c109dae4
Author:    Johan Sjölen <jsjolen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c109dae48c61c6fbeacadf59d509d37d2c4d2bb8
Stats:     23 lines in 4 files changed: 0 ins; 0 del; 23 mod

8301513: Replace NULL with nullptr in os_cpu/windows_x86

Reviewed-by: kbarrett

-------------

PR: https://git.openjdk.org/jdk/pull/12341