RFR: 8292269: Log more CDS failure messages in the warning channel
Matias Saavedra Silva
matsaave at openjdk.org
Sat Feb 4 03:03:32 UTC 2023
When -Xshare:auto is used, FileMapInfo::fail_continue() prints the diagnostic message to the Info channel instead of Warning. This was necessary in the past because CDS would failed to load for many reasons (e.g., failure to mmap due to ASLR) that are not the fault of the user. If we printed the message in the Warning channel, the user would be overwhelmed and would ultimately ignore the warnings, rendering them useless.
However, currently CDS is much more reliable. For some error conditions that require user attention, we should consider changing the failure logs to use the Warning channel.
Since only the "warning" and "info" channels are used, they can each have their own methods where fail_continue() defaults to the warning channel. Some messages must remain in the "info" channel as their inclusion would make the output too verbose. Verified with tier1-4 tests
-------------
Commit messages:
- CRC error now warning
- Merge branch 'master' into cdsWarning_8292269
- 8292269: Log more CDS failure messages in the warning channel
Changes: https://git.openjdk.org/jdk/pull/12419/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12419&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8292269
Stats: 17 lines in 3 files changed: 0 ins; 0 del; 17 mod
Patch: https://git.openjdk.org/jdk/pull/12419.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/12419/head:pull/12419
PR: https://git.openjdk.org/jdk/pull/12419
More information about the hotspot-runtime-dev
mailing list