RFR: 8298293: NMT: should os::realloc() API take flags as arguments?

[David Holmes]

On Fri, 3 Feb 2023 23:02:53 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> Please review this enhancement, which adds `assert` to make sure that we are not changing the NMT flags when calling `os::realloc()`
> 
> We also fix a bug, which the `assert` caught.
> 
> Passes Mach5 tier1,2,3,4,5

Took me a little bit to get my head around the control flow here but this seems quite reasonable.

Thanks.

P.S is it worth changing the bug synopsis now to reflect the actual changes?

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12422