RFR: 8301095: [s390x] TestDwarf.java fails [v4]

Tyler Steele tsteele at openjdk.org
Mon Feb 6 14:25:17 UTC 2023


On Mon, 6 Feb 2023 04:37:29 GMT, Amit Kumar <duke at openjdk.org> wrote:

>> TestDwarf.java fails on s390 due to incorrect returned frame. for dereference_null crash, the (return) pc was selected from gpr14 (in accordance with z-ABI) but correct (return) pc was present at "return_pc" offset. This PR introduces an additional check for the frame type detection. 
>> Special Thanks to @RealLucy
>
> Amit Kumar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into test_dwarf
>  - addressing Lutz comments
>  - no need to fetch sender_sp again
>  - updates header year
>  - adds additional check for frame detection

Marked as reviewed by tsteele (Committer).

These changes LGTM also.

-------------

PR: https://git.openjdk.org/jdk/pull/12306


More information about the hotspot-runtime-dev mailing list