RFR: JDK-8301661: Enhance os::pd_print_cpu_info on macOS and Windows
David Holmes
dholmes at openjdk.org
Tue Feb 7 04:32:43 UTC 2023
On Mon, 6 Feb 2023 13:12:16 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> From what I see, currently we use the Makefile to set the lib deps, should I remove the pragma and use the Makefile ?
I'm asking the build folk if they have any preference/concerns.
> Regarding the processor count , probably we do not want to malloc anyway in pd_print_cpu_info so we have to live with the space buf provides.
True. I still think we might reuse processor_count(). Showing zero very early during VM init is not really an issue.
> Btw what you think about shortening the info, e.g. check if all processors have the same (M)Hz values and if it is the case just print once, this might look better and much less redundant in the output ?
As this is intended as fairly general information shortening would be good - especially if the values reported are the same. Do we need to report all processors, or can we just use one as representative?
-------------
PR: https://git.openjdk.org/jdk/pull/12403
More information about the hotspot-runtime-dev
mailing list