RFR: 8292269: Log more CDS failure messages in the warning channel

[Matias Saavedra Silva]

On Tue, 7 Feb 2023 01:10:37 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> I agree that the `fail_continue` is not the ideal name for what this is trying to accomplish: log a message and *possibly* fail. 
>> 
>> That being said, I felt it was appropriate to abstract away the need to manage `LogLevel` as only Info and Warning are used with `fail_continue`. If someone does want to use any of the other channels, like debug, error, etc, they can still use the `fail_continue` variant that excepts a `LogLevel`, but they wouldn't have to worry about it otherwise. I think the binary option of warning vs no warning can help to keep it simple.
>
> In that case I return to "It is better to name a method by what it does do rather than what it doesn't." So `fail_continue` and `fail_continue_warn`?

To be in line with @dholmes-ora's suggestion, would we use the names `notify_failure` and `notify_failure_warn` ? That seems a bit redundant and ambiguous to me, so I propose `notify_failure` for the warning channel and `log_failure` for the info channel and other possible levels.

-------------

PR: https://git.openjdk.org/jdk/pull/12419