RFR: JDK-8301749: Tracking malloc pooled memory size [v2]
David Holmes
dholmes at openjdk.org
Wed Feb 8 21:57:43 UTC 2023
On Wed, 8 Feb 2023 02:49:02 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Johan Sjölen has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - Fix the test
>> - Note man section
>> - Add test
>> - Reimplement malloc_info as requested
>
> General idea is fine - thanks for implementing.
>
> There is unnecessary ifdef usage, and also a query about the existence check, below.
>
> This needs a jcmd documentation update - closed MR to update ` closed/src/jdk.jcmd/share/man/jcmd.md` and then include the updated jcmd.1 manpage file here.
> @dholmes-ora, I'll add a closed PR when everything else has received thumbs up here.
Okay but note you need to integrate the jcmd.1 changes as part of this PR too.
Also (as @vidmik reminded me):
-------------
PR: https://git.openjdk.org/jdk/pull/12455
More information about the hotspot-runtime-dev
mailing list