RFR: JDK-8301749: Tracking malloc pooled memory size [v2]

David Holmes dholmes at openjdk.org
Wed Feb 8 21:57:46 UTC 2023


On Wed, 8 Feb 2023 07:41:44 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Fix the test
>>  - Note man section
>>  - Add test
>>  - Reimplement malloc_info as requested
>
> src/hotspot/os/linux/mallocInfoDcmd.cpp line 39:
> 
>> 37:   size_t size;
>> 38:   ALLOW_C_FUNCTION(::open_memstream, FILE* stream = ::open_memstream(&buf, &size);)
>> 39:   if (!os::Linux::malloc_info(stream)) {
> 
> Style nit, can you change this to `if (os::Linux::malloc_info(stream) == 0)` ? Using `!` it reads like the failure branch.

Yes - again no implicit booleans

-------------

PR: https://git.openjdk.org/jdk/pull/12455


More information about the hotspot-runtime-dev mailing list