RFR: JDK-8301990: Separate Arguments::parse into two phases [v2]

Justin King jcking at openjdk.org
Tue Feb 14 16:10:49 UTC 2023


On Tue, 14 Feb 2023 16:03:04 GMT, Justin King <jcking at openjdk.org> wrote:

>> src/hotspot/share/runtime/arguments.cpp line 3788:
>> 
>>> 3786: static const char* const hotspotrc = ".hotspotrc";
>>> 3787: 
>>> 3788: class Arguments::PreprocessedImpl final : public CHeapObj<mtArguments> {
>> 
>> I preferred this named `PrepProcessedArguments`. I don't see why you needed to change this name to get rid of the void* field ???
>
> I can go with `PreprocessedArguments`. kimbarrett@ suggested getting rid of void* to avoid casting. I can just predeclare as PreprocessedArguments.

Done. Replaced PreprocessedImpl with PreprocessedArguments and forward declared to get rid of void*.

-------------

PR: https://git.openjdk.org/jdk/pull/12458


More information about the hotspot-runtime-dev mailing list