RFR: 8296158: Refactor the verification of CDS region checksum [v2]

Matias Saavedra Silva matsaave at openjdk.org
Tue Feb 14 22:12:10 UTC 2023


On Tue, 14 Feb 2023 22:07:52 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Consolidate the two old functions
>> 
>> - `FileMapInfo::region_crc_check(char* buf, size_t size, int expected_crc)`
>> - `FileMapInfo::verify_region_checksum(int i)`
>> 
>> Into a single function `FileMapRegion::check_region_crc()`.
>> 
>> Also performed some minor renaming and removed a useless API.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @matias9927 suggestions

LGTM!

-------------

Marked as reviewed by matsaave (Author).

PR: https://git.openjdk.org/jdk/pull/12424


More information about the hotspot-runtime-dev mailing list