RFR: JDK-8301990: Separate Arguments::parse into two phases [v3]

David Holmes dholmes at openjdk.org
Wed Feb 15 04:49:45 UTC 2023


On Tue, 14 Feb 2023 16:10:42 GMT, Justin King <jcking at openjdk.org> wrote:

>> Separate out some logic from `Arguments::parse` into a separate preceding phase, preprocessing. See JDK-8301990 and JDK-8299196 for more details.
>
> Justin King has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Rename PreprocessedImpl to PreprocessedArguments
>   
>   Signed-off-by: Justin King <jcking at google.com>

src/hotspot/share/runtime/arguments.cpp line 3796:

> 3794:                             mod_vm_options_args("vm_options_args"),
> 3795:                             mod_java_tool_options_args("env_var='JAVA_TOOL_OPTIONS'"),
> 3796:                             mod_java_options_args("env_var='_JAVA_OPTIONS'") {}

Indentation is off - args should align on the `"` of the first arg.

-------------

PR: https://git.openjdk.org/jdk/pull/12458


More information about the hotspot-runtime-dev mailing list