RFR: 8300645: Revert julong changes from 8194232 after 8292083
Severin Gehwolf
sgehwolf at openjdk.org
Wed Feb 15 10:08:55 UTC 2023
On Tue, 14 Feb 2023 21:15:10 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> @iklam After some thought, moving to a utility would need to move it into a utility preprocessor `macro` since it uses `GET_CONTAINER_INFO` macros. Would you prefer that over the current version? Or is that not the way to go? Just checking..
>
> My suggestion is to first fix the `GET_CONTAINER_INFO` macros so that the logging works for julong types. That would address the main concern of this PR. How about this?
>
> https://github.com/openjdk/jdk/compare/master...iklam:jdk:temp-improve-get-container-info-macros?expand=1
>
> (the above changeset also simplifies `GET_CONTAINER_INFO_CPTR` so you don't need to specify the string length twice).
>
> After that, if you want to consolidate the current logic to an utility function in a separate PR, that's fine too, but I think the current logic is correct (although a bit verbose).
OK, thanks!
-------------
PR: https://git.openjdk.org/jdk/pull/12166
More information about the hotspot-runtime-dev
mailing list