RFR: 8300658: memory_and_swap_limit() reporting wrong values on systems with swapaccount=0 [v4]

Severin Gehwolf sgehwolf at openjdk.org
Thu Feb 16 17:23:02 UTC 2023


> Please review this change which brings the hotspot code up to date with how the Java metrics behave. On a system where swap accounting is disabled `VM.info` jcmd - for example - no longer reports an unsupported metric, but the memory limit instead as that is actually what is being in place.
> 
> I had to update the `TestMemoryWithCgroupV1.java` test as it skipped the swappiness testing based on the now gone output.
> 
> Testing:
> - [x] Linux container tests on cg1 and cg2 with and without swap accounting.
> - [x] New regression test fails on unpatched systems with `swapaccount=0` kernel option. Passes after.
> - [x] GHA (windows tier1 failure is unrelated).
> 
> Thoughts?

Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:

  Use OSCONTAINER_ERROR constant instead

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12262/files
  - new: https://git.openjdk.org/jdk/pull/12262/files/80821ce8..8d6c6601

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12262&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12262&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/12262.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12262/head:pull/12262

PR: https://git.openjdk.org/jdk/pull/12262


More information about the hotspot-runtime-dev mailing list