RFR: 8292269: Log more CDS failure messages in the warning channel [v5]
Matias Saavedra Silva
matsaave at openjdk.org
Sat Feb 18 01:21:17 UTC 2023
> When -Xshare:auto is used, FileMapInfo::fail_continue() prints the diagnostic message to the Info channel instead of Warning. This was necessary in the past because CDS would failed to load for many reasons (e.g., failure to mmap due to ASLR) that are not the fault of the user. If we printed the message in the Warning channel, the user would be overwhelmed and would ultimately ignore the warnings, rendering them useless.
>
> However, currently CDS is much more reliable. For some error conditions that require user attention, we should consider changing the failure logs to use the Warning channel.
>
> Logging will now shift toward Unified Logging, so `fail_continue()` will be replaced with `log_info(cds)` and `log_warning(cds)`. Relevant tests are updated to accommodate this change. Verified with tier1-4 tests
Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:
- Merge
- More test fixes
- Fixed tests
- RequiresSharedSpaces now leads to VM exit later
- Replaced fail_continue with log_info and log_warning
- Merge branch 'master' into cdsWarning_8292269
- CRC error now warning
- Merge branch 'master' into cdsWarning_8292269
- 8292269: Log more CDS failure messages in the warning channel
-------------
Changes: https://git.openjdk.org/jdk/pull/12419/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12419&range=04
Stats: 113 lines in 12 files changed: 16 ins; 43 del; 54 mod
Patch: https://git.openjdk.org/jdk/pull/12419.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/12419/head:pull/12419
PR: https://git.openjdk.org/jdk/pull/12419
More information about the hotspot-runtime-dev
mailing list