RFR: JDK-8301990: Separate Arguments::parse into two phases [v3]
Justin King
jcking at openjdk.org
Sat Feb 18 18:11:27 UTC 2023
On Thu, 16 Feb 2023 10:56:01 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rename PreprocessedImpl to PreprocessedArguments
>>
>> Signed-off-by: Justin King <jcking at google.com>
>
> I am not convinced that the reason behind this change - getting rid of NMTPreInit - is something we should do. See my comments under https://bugs.openjdk.org/browse/JDK-8299196. I think we should discuss that first.
>
> I did not look at this patch to see if it has merits beyond that.
Bumping to 3 reviewers to prevent accidental integration until further discussions with @tstuefe in the future.
-------------
PR: https://git.openjdk.org/jdk/pull/12458
More information about the hotspot-runtime-dev
mailing list