RFR: JDK-8302810: NMT gtests don't correctly check for marked ranges

[Gerard Ziemski]

On Sat, 18 Feb 2023 06:25:00 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> We have the helper functions `GtestUtils::mark_range` and `GtestUtils::check_range`. One fills a range with a byte pattern, and the other checks that range.
> 
> The latter does not assert - it just returns a boolean value. But its name implies it does, in fact, assert (as similar check_... functions in hotspot).
> 
> It is used without ASSERT_TRUE or EXPECT_TRUE in several places, which makes these tests ignore errors. This caused https://bugs.openjdk.org/browse/JDK-8302811 to be hidden.
> 
> ----
> 
> Patch adds the necessary assertions (EXPECT_, in this case, since its used in a non-void subfunction).
> 
> It also renames `GtestUtils::check_range` to `GtestUtils::is_range_checked`, which more clearly indicates that it returns a boolean value and won't assert on itself.

LGTM, thank you for fixing this.

-------------

Marked as reviewed by gziemski (Committer).

PR: https://git.openjdk.org/jdk/pull/12629