Integrated: 8300658: memory_and_swap_limit() reporting wrong values on systems with swapaccount=0

Severin Gehwolf sgehwolf at openjdk.org
Mon Feb 20 17:10:37 UTC 2023


On Fri, 27 Jan 2023 17:09:35 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this change which brings the hotspot code up to date with how the Java metrics behave. On a system where swap accounting is disabled `VM.info` jcmd - for example - no longer reports an unsupported metric, but the memory limit instead as that is actually what is being in place.
> 
> I had to update the `TestMemoryWithCgroupV1.java` test as it skipped the swappiness testing based on the now gone output.
> 
> Testing:
> - [x] Linux container tests on cg1 and cg2 with and without swap accounting.
> - [x] New regression test fails on unpatched systems with `swapaccount=0` kernel option. Passes after.
> - [x] GHA (linux tier1 failure is unrelated).
> 
> Thoughts?

This pull request has now been integrated.

Changeset: e47e9ec0
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e47e9ec05b630c82182c7843365dfd90fdaa18a0
Stats:     82 lines in 5 files changed: 65 ins; 14 del; 3 mod

8300658: memory_and_swap_limit() reporting wrong values on systems with swapaccount=0

Reviewed-by: jsjolen, iklam

-------------

PR: https://git.openjdk.org/jdk/pull/12262


More information about the hotspot-runtime-dev mailing list