RFR: 8301106 allow cds interned strings to be moved by gc [v2]

David Holmes dholmes at openjdk.org
Tue Feb 21 01:16:33 UTC 2023


On Sat, 18 Feb 2023 04:56:22 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/cds/heapShared.cpp line 592:
>> 
>>> 590:   assert(HeapShared::can_write(), "must be");
>>> 591: 
>>> 592:   {
>> 
>> Why do  you need a new  scope here?
>
> I used the scope to mark that the two archiving operations must be done within the scope of
> 
> 
> {
>     init_seen_objects_table();
>        ....
>     delete_seen_objects_table();
> }
> 
> 
> And the `delete_seen_objects_table()` must be called before the rest of the function can proceed.

That seems an unusual convention when the code executes sequentially anyway.

-------------

PR: https://git.openjdk.org/jdk/pull/12607


More information about the hotspot-runtime-dev mailing list