RFR: 8301106 allow cds interned strings to be moved by gc [v2]

[Ioi Lam]

On Tue, 21 Feb 2023 00:55:57 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - renamed obsolete functions to ArchiveHeapLoader::is_in_use()
>>  - fixed typos in comment
>
> src/hotspot/share/cds/heapShared.cpp line 426:
> 
>> 424:   oop shared_strings_array = StringTable::init_shared_table(_dumped_interned_strings);
>> 425:   bool success = archive_reachable_objects_from(1, _default_subgraph_info, shared_strings_array, /*is_closed_archive=*/ false);
>> 426:   guarantee(success, "shared strings array must point to only archivable objects");
> 
> What could cause this to fail? Do we need a more graceful bailout in release builds?

It should never fail. I could've used an assert but made it a guarantee since this is rather new code and I am paranoid.

-------------

PR: https://git.openjdk.org/jdk/pull/12607