RFR: 8302888: containers/docker/TestJcmd.java fails when run as root under podman [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Tue Feb 21 09:41:56 UTC 2023
On Mon, 20 Feb 2023 22:45:21 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Only call getId() in the podman case
>
> test/hotspot/jtreg/containers/docker/TestJcmd.java line 173:
>
>> 171:
>> 172: String uid = getId("-u");
>> 173: if (IS_PODMAN && !ROOT_UID.equals(uid)) {
>
> Suggestion - to avoid execution in non-podman case:
>
> if (IS_PODMAN && !ROOT_UID.equals(getId("-u"))) {
>
> Alternatively in `generateCustomDockerfile` we could always check the uid and stash that away for later use here?
Thanks, updated!
-------------
PR: https://git.openjdk.org/jdk/pull/12673
More information about the hotspot-runtime-dev
mailing list