RFR: 8303070: Memory leak in DCmdArgument<char*>::parse_value [v2]

[David Holmes]

On Fri, 24 Feb 2023 00:54:37 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed redundant clause
>
> src/hotspot/share/services/diagnosticArgument.cpp line 195:
> 
>> 193:   if (has_default() && _default_string != nullptr) {
>> 194:     this->parse_value(_default_string, strlen(_default_string), THREAD);
>> 195:     if (HAS_PENDING_EXCEPTION) {
> 
> Why drop the exception check? Can `parse_value` not raise an exception?

No it can't - pure C++ code. I think this was just a copy'n'paste error from the other specializations.

-------------

PR: https://git.openjdk.org/jdk/pull/12737