RFR: 8262895: [macos_aarch64] runtime/CompressedOops/CompressedClassPointers.java fails with 'Narrow klass base: 0x0000000000000000' missing from stdout/stderr [v2]
David Holmes
dholmes at openjdk.org
Fri Feb 24 02:42:15 UTC 2023
On Thu, 23 Feb 2023 16:27:33 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
>> The test runtime/CompressedOops/CompressedClassPointers.java does not reliably pass on Mac OSX on either x86 or aarch64, so it is disabled for that platform.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>
> Improved comment
A couple of nits but approved in advance. Thanks.
test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java line 28:
> 26: * @bug 8024927
> 27: * @summary Testing address of compressed class pointer space as best as possible.
> 28: * @comment Testing compressed class pointers without compressed oops is not possible
Nit: comment could go immediately before the `@requires os.family != mac`
test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java line 29:
> 27: * @summary Testing address of compressed class pointer space as best as possible.
> 28: * @comment Testing compressed class pointers without compressed oops is not possible
> 29: on MacOS because the heap is given an arbitrary address that occasionally
Nit: extra space after `an`
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12234
More information about the hotspot-runtime-dev
mailing list