RFR: 8303070: Memory leak in DCmdArgument<char*>::parse_value [v2]

[Coleen Phillimore]

On Fri, 24 Feb 2023 15:46:32 GMT, Justin King <jcking at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed redundant clause
>
> src/hotspot/share/services/diagnosticArgument.cpp line 183:
> 
>> 181: template <> void DCmdArgument<char*>::parse_value(const char* str,
>> 182:                                                   size_t len, TRAPS) {
>> 183:   if (str == nullptr) {
> 
> Do we need to call free here? Not sure if str is actually ever null in practice.

I have the same question.  Why don't we call free if _value is non-null?

-------------

PR: https://git.openjdk.org/jdk/pull/12737