RFR: 8301715: CDS should be disabled in exploded JDK

[Calvin Cheung]

On Wed, 22 Feb 2023 03:07:46 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> CDS is not supported by the exploded JDK yet it is enabled anyway, leading to guaranteed failure. Now there will be no attempt to map the CDS archive on an exploded build. Verified with tier 1 tests.

Fix looks good with one nit.
I'm wondering if the following check can be removed or converted to an assert in  `FileMapInfo::Initialize()`:


  if (!Arguments::has_jimage()) {
    FileMapInfo::fail_continue("The shared archive file cannot be used with an exploded module build.");
    return false;
  }

src/hotspot/share/runtime/arguments.cpp line 2923:

> 2921:   }
> 2922: 
> 2923:   // Disable cds for exploded image

Can you use uppercase for CDS?

-------------

PR: https://git.openjdk.org/jdk/pull/12705