RFR: 8303070: Memory leak in DCmdArgument<char*>::parse_value [v4]
David Holmes
dholmes at openjdk.org
Sat Feb 25 02:36:36 UTC 2023
> If we have a default value for the char* DCmdArgument we copy it into the `_value` field using `parse_value` to make a copy in C-heap. If we then parse an actual argument value, we replace the default but don't free it. The parse method needs to use realloc.
>
> Thanks to @jcking for spotting the cause.
>
> Testing: tiers 1-3
>
> Thanks.
David Holmes has updated the pull request incrementally with one additional commit since the last revision:
Update test coverage for the empty and null cases
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/12737/files
- new: https://git.openjdk.org/jdk/pull/12737/files/19fdfadf..53666402
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=12737&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=12737&range=02-03
Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/12737.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/12737/head:pull/12737
PR: https://git.openjdk.org/jdk/pull/12737
More information about the hotspot-runtime-dev
mailing list