RFR: 8301715: CDS should be disabled in exploded JDK [v2]

[Ioi Lam]

On Fri, 24 Feb 2023 19:21:26 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> CDS is not supported by the exploded JDK yet it is enabled anyway, leading to guaranteed failure. Now there will be no attempt to map the CDS archive on an exploded build. Verified with tier 1 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replaced condition with assert

Changes requested by iklam (Reviewer).

src/hotspot/share/runtime/arguments.cpp line 2927:

> 2925:     UseSharedSpaces = false;
> 2926:     RequireSharedSpaces = false;
> 2927:   }

I think you should call `no_shared_spaces()` instead. That way, the VM will print an error message and exit if `-Xshare:on` is specified.

-------------

PR: https://git.openjdk.org/jdk/pull/12705