RFR: 8299343: Windows: Invalid thread_native_entry declaration
David Holmes
dholmes at openjdk.org
Tue Jan 3 06:43:48 UTC 2023
On Sun, 25 Dec 2022 01:19:29 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> Please review this change to the Windows version of thread_native_entry. It
> is changed from being inconsistently declared (both file-scoped and external)
> to consistently being a private static member function in os::win32. It's
> signature is also changed to match where it's used, eliminating the need for a
> function pointer cast.
>
> Testing:
> mach5 tier1
Marked as reviewed by dholmes (Reviewer).
src/hotspot/os/windows/os_windows.cpp line 514:
> 512:
> 513: // Thread start routine for all newly created threads
> 514: // Called with the associated Thread* as the argument.
Nit: please terminate existing comment with a period - thanks.
-------------
PR: https://git.openjdk.org/jdk/pull/11787
More information about the hotspot-runtime-dev
mailing list