RFR: JDK-8298908: Instrument Metaspace for ASan [v2]

[Justin King]

On Wed, 4 Jan 2023 06:00:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Exclude more zapping when ASan is in use
>>   
>>   Signed-off-by: Justin King <jcking at google.com>
>
> src/hotspot/share/runtime/os.cpp line 949:
> 
>> 947: // parent stack frames, read outside of initialized memory, and etc. So we tell ASan to not
>> 948: // instrument this function.
>> 949: NO_SANITIE_ADDRESS void os::print_hex_dump(outputStream* st, address start, address end,
> 
> Typo: NO_SANITIE_ADDRESS ->NO_SANITIZE_ADDRESS ?

Yep, fixed typo.

> src/hotspot/share/sanitizers/address.h line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
> 
> Oracle didn't write this, it should have your/your-company's copyright.

Ah, okay. Updated.

> src/hotspot/share/sanitizers/address.h line 44:
> 
>> 42: #endif
>> 43: #else
>> 44: #define NO_SANITIE_ADDRESS
> 
> Typos

Whoops, thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/11702