RFR: 8299329: Assertion failure with fastdebug build when trying to use CDS without classpath [v3]

[Ashutosh Mehra]

On Wed, 4 Jan 2023 20:31:57 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix whitespace
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> test/hotspot/jtreg/runtime/cds/appcds/WrongClasspath.java line 51:
> 
>> 49:     // Run with a jar file that differs from the original jar file by the first character only: -cp mello.jar
>> 50:     // Shared class paths mismatch should be detected.
>> 51:     String mellojar = appJarInWorkDir.replace("hello.jar", "mello.jar");
> 
> I am not sure if we need to add more APIs to JarBuilder. Since you just need two files "hello.jar" and "mello.jar", I think that can be done like:
> 
> 
> import java.nio.file.Paths;
> ...
> String helloJar = "hello.jar";
> String melloJar = "mello.jar";
> Files.copy(Paths.get(appJar), Paths.get(helloJar), StandardCopyOption.COPY_ATTRIBUTES);
> Files.copy(Paths.get(appJar), Paths.get(melloJar), StandardCopyOption.COPY_ATTRIBUTES);

yup, that would do as well. Pushed a commit as per the suggestion.

-------------

PR: https://git.openjdk.org/jdk/pull/11781