RFR: 8299343: Windows: Invalid thread_native_entry declaration

Kim Barrett kbarrett at openjdk.org
Thu Jan 5 21:32:58 UTC 2023


On Thu, 5 Jan 2023 02:47:50 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> > Could we refactor the rest of the platform specific thread entry definitions to be static members too after this change?
> 
> I prefer not. There is no general reason these thread entry routines should be part of the os::XXX classes. All the crud in the Windows version that required access to os::win32 is to address a win32 bug.

I concur with David, preferring not to do the suggested refactoring.

Out of curiosity, I took a look at the referenced bug. Wow! That took some
serious sleuthing! (Sorry, but the bug is closed to non-Oracle access.)

-------------

PR: https://git.openjdk.org/jdk/pull/11787


More information about the hotspot-runtime-dev mailing list