RFR: 8299343: Windows: Invalid thread_native_entry declaration
Kim Barrett
kbarrett at openjdk.org
Thu Jan 5 21:36:48 UTC 2023
On Thu, 5 Jan 2023 03:00:04 GMT, David Holmes <dholmes at openjdk.org> wrote:
>>> > Could we refactor the rest of the platform specific thread entry definitions to be static members too after this change?
>>>
>>> I prefer not. There is no general reason these thread entry routines should be part of the os::XXX classes. All the crud in the Windows version that required access to os::win32 is to address a win32 bug.
>>
>> Fair Point. I'm now a little curious as to why we couldn't make create_process_or_thread and Ept public though
>
>> I'm now a little curious as to why we couldn't make create_process_or_thread and Ept public though
>
> To get rid of the friend declaration there were two options - Kim prefers the one he presented.
Thanks for reviews @dholmes-ora and @iklam .
-------------
PR: https://git.openjdk.org/jdk/pull/11787
More information about the hotspot-runtime-dev
mailing list