RFR: 8299343: Windows: Invalid thread_native_entry declaration [v2]

Kim Barrett kbarrett at openjdk.org
Thu Jan 5 22:07:37 UTC 2023


> Please review this change to the Windows version of thread_native_entry.  It
> is changed from being inconsistently declared (both file-scoped and external)
> to consistently being a private static member function in os::win32.  It's
> signature is also changed to match where it's used, eliminating the need for a
> function pointer cast.
> 
> Testing:
> mach5 tier1

Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into thread_native_entry
 - missing period
 - use static member function

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11787/files
  - new: https://git.openjdk.org/jdk/pull/11787/files/c96a8f45..a8b14577

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11787&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11787&range=00-01

  Stats: 4681 lines in 279 files changed: 2367 ins; 1848 del; 466 mod
  Patch: https://git.openjdk.org/jdk/pull/11787.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11787/head:pull/11787

PR: https://git.openjdk.org/jdk/pull/11787


More information about the hotspot-runtime-dev mailing list