RFR: 8255119: Monitor::wait takes signed integer as timeout

David Holmes dholmes at openjdk.org
Mon Jan 9 22:23:54 UTC 2023


On Mon, 9 Jan 2023 07:52:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Please review this simple cleanup of the JVM `Monitor`/`PlatformMonitor` code so that timeouts are expressed as unsigned rather than signed values i.e. `int64_t`/`jlong` -> `uint64_t`.
> 
> Testing:
>  - tiers 1-3
>  - all builds in Oracle CI in tiers 1-5, plus shenandoah GC on LInux x64
> 
> Thanks

I realized the windows code still had a pre-existing truncation bug due to the 64-bit -> 32-bit conversion. In practice it is not an issue as we never use such large timeout values in the VM. Re-running Windows builds/tests.

-------------

PR: https://git.openjdk.org/jdk/pull/11898


More information about the hotspot-runtime-dev mailing list