RFR: 8298065: Provide more information in message of NoSuchFieldError [v7]

David Holmes dholmes at openjdk.org
Tue Jan 10 04:01:56 UTC 2023


On Mon, 9 Jan 2023 22:37:17 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/oops/symbol.hpp line 278:
>> 
>>> 276:   //  'double' or 'java.lang.Object[][]'.
>>> 277:   void print_as_signature_external_parameters(outputStream *os);
>>> 278:   void print_signature_as_external_field_type(outputStream *os);
>> 
>> Should this be `print_as_signature_external_field_type`?
>
> I think Matias's version is more grammatically correct. Maybe we should rename the two existing functions
> 
> 
> symbol.hpp:  void print_as_signature_external_return_type(outputStream *os);
> symbol.hpp:  void print_as_signature_external_parameters(outputStream *os);
> 
> 
> to `print_signature_as_xxx`.

These are methods on VMSymbol that print the VMSymbol as a signature, so the naming is correct.

-------------

PR: https://git.openjdk.org/jdk/pull/11745


More information about the hotspot-runtime-dev mailing list