RFR: JDK-8298908: Instrument Metaspace for ASan [v11]

[Justin King]

On Tue, 10 Jan 2023 21:55:51 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use macros from <sanitizer/asan_interface.h> when available and update justification
>>   
>>   Signed-off-by: Justin King <jcking at google.com>
>
> src/hotspot/share/sanitizers/address.h line 45:
> 
>> 43: #else
>> 44: #define NO_SANITIZE_ADDRESS
>> 45: #endif
> 
> The `NO_SANITIZE_ADDRESS` macro doesn't seem to be used by this patch.

Yeah, was used previously. Removed it for now, can always add it back when needed later.

> src/hotspot/share/sanitizers/address.h line 53:
> 
>> 51: // <sanitizer/asan_interface.h>. When ASan is not available this macro is a NOOP which preserves the
>> 52: // arguments, ensuring they still compile, but ensures they are stripped due to being unreachable.
>> 53: // This helps ensure developers do not accidently break ASan builds.
> 
> Maybe the "When ASan is available ... do not accidently break ASan builds." parts can be combined for the two macros to avoid duplication?

Done.

-------------

PR: https://git.openjdk.org/jdk/pull/11702