RFR: JDK-8300069: Left shift of negative value in share/adlc/dict2.cpp [v4]
Kim Barrett
kbarrett at openjdk.org
Tue Jan 17 09:00:18 UTC 2023
On Fri, 13 Jan 2023 16:01:55 GMT, Justin King <jcking at openjdk.org> wrote:
>> Refactor `hashstr` to use unsigned integrals to avoid undefined behavior.
>
> Justin King has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>
> - Resolve conflicts
>
> Signed-off-by: Justin King <jcking at google.com>
> - Revert share/adlc/dict2.cpp changes
>
> Signed-off-by: Justin King <jcking at google.com>
> - Silence undefined behavior checking for left hand side of shift
>
> Signed-off-by: Justin King <jcking at google.com>
> - Left shift of negative value in share/adlc/dict2.cpp
>
> Signed-off-by: Justin King <jcking at google.com>
Looks good.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11977
More information about the hotspot-runtime-dev
mailing list