RFR: JDK-8300222: Replace NULL with nullptr in share/logging

Coleen Phillimore coleenp at openjdk.org
Tue Jan 17 14:21:17 UTC 2023


On Mon, 16 Jan 2023 19:19:20 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Do the conversion in the share/logging sub-directory and all of its files.

Scrolled through can confirm only trivial change.  I had one question.

src/hotspot/share/logging/logDecorations.cpp line 42:

> 40:     if (os::get_host_name(buffer, sizeof(buffer))) {
> 41:       host_name = os::strdup_check_oom(buffer);
> 42:       const char* old_value = Atomic::cmpxchg(&_host_name, (const char*)nullptr, host_name);

I wonder if you need this cast with nullptr ?

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12014


More information about the hotspot-runtime-dev mailing list