RFR: JDK-8300222: Replace NULL with nullptr in share/logging

David Holmes dholmes at openjdk.org
Wed Jan 18 06:07:20 UTC 2023


On Mon, 16 Jan 2023 19:19:20 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Do the conversion in the share/logging sub-directory and all of its files.

Looks good. Thanks.

src/hotspot/share/logging/logAsyncWriter.cpp line 195:

> 193:   if (self->_initialized) {
> 194:     Atomic::release_store_fence(&AsyncLogWriter::_instance, self);
> 195:     // All readers of _instance after the fence see non-nullptr.

Nit: When "null" or "NULL" are used in prose there is some ambiguity about whether  it is referring to the general concept of nullness or the value NULL. In this case I would have written this as "see non-null". I find "non-nullptr" a bit jarring.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12014


More information about the hotspot-runtime-dev mailing list