RFR: JDK-8298908: Instrument Metaspace for ASan [v12]

Justin King jcking at openjdk.org
Thu Jan 19 17:39:27 UTC 2023


On Thu, 12 Jan 2023 07:43:00 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update sanitizers/address.h based on review
>>   
>>   Signed-off-by: Justin King <jcking at google.com>
>
> src/hotspot/share/memory/metaspace/chunkManager.cpp line 311:
> 
>> 309:     ASAN_UNPOISON_MEMORY_REGION(c->base() + chunklevel::word_size_for_level(old_level),
>> 310:                                 (c->word_size() - chunklevel::word_size_for_level(old_level)) *
>> 311:                                 BytesPerWord);
> 
> @jcking Can we simplify the calculation a bit here? By taking the old size beforehand and use that instead of chunklevel::word_size_for_level?

Done.

-------------

PR: https://git.openjdk.org/jdk/pull/11702


More information about the hotspot-runtime-dev mailing list