RFR: JDK-8300244: Replace NULL with nullptr in share/interpreter/ [v2]

David Holmes dholmes at openjdk.org
Fri Jan 20 05:07:32 UTC 2023


On Thu, 19 Jan 2023 20:00:44 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Do the conversion in the share/interpreter/ sub-directory and all of its files.
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Manual fixes

Generally looks good. Two macros to undo I think.

Thanks.

src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp line 1368:

> 1366:       }
> 1367: 
> 1368: #define nullptr_COMPARISON_NOT_OP(name)                                         \

These ones don't look right. I think this is the generic "null" forced into uppercase because it is a macro.

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12033


More information about the hotspot-runtime-dev mailing list