RFR: JDK-8300087: Replace NULL with nullptr in share/cds/

David Holmes dholmes at openjdk.org
Fri Jan 20 05:38:31 UTC 2023


On Thu, 19 Jan 2023 10:49:38 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Do the conversion in the share/cds/ sub-directory and all of its files.

LGTM! Thanks.

One suggestion below.

src/hotspot/share/cds/filemap.cpp line 2498:

> 2496:   // do the same for mapped open archive heap regions
> 2497:   if (num_open_heap_regions != 0) {
> 2498:     assert(open_heap_regions != nullptr, "null open_heap_regions array with non-zero count");

Nit: suggest "Null" to match similar message at L2514.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12090


More information about the hotspot-runtime-dev mailing list