RFR: JDK-8298908: Instrument Metaspace for ASan [v12]

[Justin King]

On Mon, 16 Jan 2023 11:03:40 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update sanitizers/address.h based on review
>>   
>>   Signed-off-by: Justin King <jcking at google.com>
>
> The build changes were trivial. You are correct that adding the build label is the appropriate thing to do, so the PR comes to the build team's attention. However, if the changes is more "incidentally" in the build system (as here, were the added flags do not really change any build behavior), then there is really nothing to say from a build perspective.
> 
> I handle such PRs in one of two ways, either I approve them saying "build changes are trivially fine". Or, in cases like this, when the *actual* change is apparently controversial, and triggers a long debate, I try to save build-dev from a lengthy and irrelevant discussion by removing the label. But sure, I should probably add a build approval as well even in those cases.

Let me double check as well before somebody sponsoring. I'll let an ASan build run through the tests tiers and see if any failures are related. The ASan test runs are not clean currently, I am working on fixing those in a unrelated series of PRs that I am sending @magicus way.

-------------

PR: https://git.openjdk.org/jdk/pull/11702