RFR: 8300806: Update googletest to v1.13.0 [v2]

Mikael Vidstedt mikael at openjdk.org
Mon Jan 23 22:07:06 UTC 2023


On Mon, 23 Jan 2023 14:03:53 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Mikael Vidstedt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update doc/building.html
>
> make/autoconf/lib-tests.m4 line 63:
> 
>> 61:         # Verify that the version is the required one.
>> 62:         GTEST_VERSION_1="`$GREP GOOGLETEST_VERSION $GTEST_FRAMEWORK_SRC/CMakeLists.txt | $SED -E -e 's/set\(GOOGLETEST_VERSION (.*)\)/\1/'`"
>> 63:         if test "x$GTEST_VERSION_1" != "x1.13.0"; then
> 
> Can you extract this value as a "constant" and put it next to `JTREG_MINIMUM_VERSION` in the top of the file? (Also in the error message)

Updated the logic to match that used for jtreg.

-------------

PR: https://git.openjdk.org/jdk/pull/12125


More information about the hotspot-runtime-dev mailing list