RFR: 8300830: Remove redundant assertion in src/hotspot/share/runtime/javaCalls.cpp

[Daniel D. Daugherty]

On Mon, 23 Jan 2023 00:30:25 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Trivial removal of redundant assertion: we previously set the state to _thread_in_Java so it can't be _thread_in_native.
> 
> Thanks.

That assert() has been there since the "Initial load" on Dec 1 2007.
I'm okay with deleting the assert() and I don't think the distance from


ThreadStateTransition::transition_from_vm(thread, _thread_in_Java, true /* check_asyncs */);


is too much. Also since this function is `JavaCallWrapper` it is expected
that the thread state should be "in Java".

Also, I agree that the change is trivial, but I think we're past the 24H window and
there are more than enough reviewers here...

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12134