RFR: 8291569: Consider removing JNI checks for signals SIGPIPE and SIGXFSZ [v2]

David Holmes dholmes at openjdk.org
Tue Jan 24 21:30:05 UTC 2023


On Tue, 24 Jan 2023 13:33:29 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> David Holmes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8291569-signals
>>  - 8291569: Consider removing JNI checks for signals SIGPIPE and SIGXFSZ
>
> Now pieces fall into place. I totally forgot about libjsig.
> 
> Thank you for your patience :) !
> 
> Seems reasonable to me also!

Thanks for the discussion and reviews @robehn  and @tstuefe 

> But setting a SIGPIPE handler - or temporarily disabling it - without signal chaining seems to be such a common pattern that we now remove the warning instead. We basically throw the hands in the air and give up.

Given changing the handler is somewhat expected/normal then issuing an alarming warning only annoys people who expect to be able to run JNI-warning free.

-------------

PR: https://git.openjdk.org/jdk/pull/12062


More information about the hotspot-runtime-dev mailing list