RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes

[David Holmes]

On Tue, 24 Jan 2023 00:16:10 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> classFileParser drops stack map frames for JDK classes (when verification is not required).
> As a result JvmtiClassFileReconstituter cannot restore the attribute for class redefinition.
> Note that if the class is in CDS archive, the frames are restored from CDS, so this issue affects only JDK classes which are not in CDS.
> This code is old (from "initial load") and I don't understand the reason it was implemented this way.
> 
> Testing: tier1-tier6

AFIUI if verification for a type is enabled then we keep the stackmap table, else we do not. Do we have an inconsistency with that rule? Do we make assumptions about verification being enabled, or not, that we should not be?

-------------

PR: https://git.openjdk.org/jdk/pull/12155