RFR: 8299858: [Metrics] Swap memory limit reported incorrectly when too large [v4]

Thomas Stuefe stuefe at openjdk.org
Wed Jan 25 14:02:06 UTC 2023


On Wed, 25 Jan 2023 13:45:28 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Please review this fix to [JDK-8292541](https://bugs.openjdk.org/browse/JDK-8292541) which adds the same handling for swap values exceeding what's possible in the non-container case. I.e. treats it as unlimited and fixes the reporting. This has been handled on the hotspot side similarly with [JDK-8292083](https://bugs.openjdk.org/browse/JDK-8292083).
>> 
>> Testing:
>> - [x] Container tests on linux x86_64 with cg v1
>> - [x] Container tests on linux x86_64 with cg v2
>> - [ ] GHA (seem to have had some infra issues, so re-running)
>
> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Do proper error checking

Good.

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12118


More information about the hotspot-runtime-dev mailing list