Integrated: 8291569: Consider removing JNI checks for signals SIGPIPE and SIGXFSZ

David Holmes dholmes at openjdk.org
Sun Jan 29 23:17:24 UTC 2023


On Wed, 18 Jan 2023 07:41:23 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Simple enhancement to skip checking of the handlers for SIGPIPE and SIGXFSZ as we really don't care if they change, and we expect that they can.
> 
> The signal checking code might seem to have a redundancy as we skip these signals in two places, but the primary use of the `do_check_signal_periodically` array is to allow for only issuing one warning per signal. I could have skipped them in either place and get the same effect but it seemed inappropriate to set the array entry and not do the check; and vice-versa.
> 
> Testing: just basic sanity test tiers 1-3. This doesn't affect any application behaviour.
> 
> There are no regression tests in this specific area and it did not seem worth the effort creating one just for this.
> 
> Thanks.

This pull request has now been integrated.

Changeset: 64b25ea0
Author:    David Holmes <dholmes at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/64b25ea0b410542635b6d99a92ec290da47c85ce
Stats:     13 lines in 1 file changed: 9 ins; 2 del; 2 mod

8291569: Consider removing JNI checks for signals SIGPIPE and SIGXFSZ

Reviewed-by: stuefe, rehn

-------------

PR: https://git.openjdk.org/jdk/pull/12062


More information about the hotspot-runtime-dev mailing list